Skip to content

Commit

Permalink
Update comments regarding _replacement_range.
Browse files Browse the repository at this point in the history
  • Loading branch information
ShikiSuen committed Apr 10, 2024
1 parent 566712f commit 95e3472
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/platform_impl/macos/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ declare_class!(
selected_range: NSRange,
_replacement_range: NSRange,
) {
// TODO: _replacement_range implementation, requiring surrounding text reporting on the Window.
// _replacement_range is currently not implemented in this crate,
// requiring surrounding text reporting on the Window. Ref: PR#3619.
trace_scope!("setMarkedText:selectedRange:replacementRange:");

// SAFETY: This method is guaranteed to get either a `NSString` or a `NSAttributedString`.
Expand Down Expand Up @@ -383,8 +384,8 @@ declare_class!(

#[method(insertText:replacementRange:)]
fn insert_text(&self, string: &NSObject, _replacement_range: NSRange) {
// TODO: _replacement_range implementation, requiring surrounding text reporting on the Window.
// Ref: https://github.com/qt/qtbase/blob/3941fe697b9fea633f85321031ece765c532d46d/src/plugins/platforms/cocoa/qnsview_complextext.mm#L41-L93
// _replacement_range is currently not implemented in this crate,
// requiring surrounding text reporting on the Window. Ref: PR#3619.
trace_scope!("insertText:replacementRange:");

// SAFETY: This method is guaranteed to get either a `NSString` or a `NSAttributedString`.
Expand Down

0 comments on commit 95e3472

Please sign in to comment.