bugfix(android): Allow Volume* keys to be passed to the user

rust-windowing · Apr 23, 2024 · 7006c7c · 7006c7c
1 parent 2491f2b
commit 7006c7c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/changelog/unreleased.md b/src/changelog/unreleased.md
@@ -255,3 +255,4 @@ changelog entry.
 - On Windows, fix cursor not confined to center of window when grabbed and hidden.
 - On macOS, fix sequence of mouse events being out of order when dragging on the trackpad.
 - On Wayland, fix decoration glitch on close with some compositors.
+- On Android, fix a regression introduced in #2748 to allow volume key events to be received again.
diff --git a/src/platform_impl/android/mod.rs b/src/platform_impl/android/mod.rs
@@ -438,10 +438,10 @@ impl<T: 'static> EventLoop<T> {
                     // Flag keys related to volume as unhandled. While winit does not have a way for applications
                     // to configure what keys to flag as handled, this appears to be a good default until winit
                     // can be configured.
-                    Keycode::VolumeUp | Keycode::VolumeDown | Keycode::VolumeMute => {
-                        if self.ignore_volume_keys {
-                            input_status = InputStatus::Unhandled
-                        }
+                    Keycode::VolumeUp | Keycode::VolumeDown | Keycode::VolumeMute
+                        if self.ignore_volume_keys =>
+                    {
+                        input_status = InputStatus::Unhandled
                     }
                     keycode => {
                         let state = match key.action() {