review feedback.

rust-windowing · Jan 1, 2022 · 6212e2e · 6212e2e
1 parent 3d5e8a8
commit 6212e2e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/platform_impl/linux/x11/util/geometry.rs b/src/platform_impl/linux/x11/util/geometry.rs
@@ -248,7 +248,7 @@ impl XConnection {
             );
 
             // The list of children isn't used
-            if children.is_null() {
+            if !children.is_null() {
                 (self.xlib.XFree)(children as *mut _);
             }
 

diff --git a/src/platform_impl/linux/x11/window.rs b/src/platform_impl/linux/x11/window.rs
@@ -432,8 +432,7 @@ impl UnownedWindow {
             }
 
             // Select XInput2 events
-            let mask = {
-                ffi::XI_MotionMask
+            let mask = ffi::XI_MotionMask
                     | ffi::XI_ButtonPressMask
                     | ffi::XI_ButtonReleaseMask
                     //| ffi::XI_KeyPressMask
@@ -444,8 +443,7 @@ impl UnownedWindow {
                     | ffi::XI_FocusOutMask
                     | ffi::XI_TouchBeginMask
                     | ffi::XI_TouchUpdateMask
-                    | ffi::XI_TouchEndMask
-            };
+                    | ffi::XI_TouchEndMask;
             xconn
                 .select_xinput_events(window.xwindow, ffi::XIAllMasterDevices, mask)
                 .queue();