Extension via vtable with dyn #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
reviewed
Feb 2, 2024
| @@ -35,6 +37,8 @@ pub trait Window: HasWindowHandle + HasRawWindowHandle05 { | |||
| fn current_monitor(&self) -> Option<MonitorId>; | |||
|
|
|||
| fn primary_monitor(&self) -> Option<MonitorId>; | |||
|
|
|||
| fn as_any(&mut self) -> &mut dyn Any; | |||
There was a problem hiding this comment.
This is not possible?
Suggested change
| fn as_any(&mut self) -> &mut dyn Any; | |
| fn as_any(&mut self) -> &mut dyn Any { | |
| self | |
| } |
What if we add Window: Any to the trait itself?
There was a problem hiding this comment.
yeah, it's not, because it'll require sized and it's not object safe, etc. it's not really a big issue though.
There was a problem hiding this comment.
You can try to pull my code and play with it, but it wasn't really working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @madsmtm @daxpedda
That's approach with
&mut dyn, it does requireas_anymethod implemented by the user, but I guess it's fine?