Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make implementors of HasRawWindowHandle v0.5 also implement v0.4's #97

Closed
wants to merge 1 commit into from
Closed

Make implementors of HasRawWindowHandle v0.5 also implement v0.4's #97

wants to merge 1 commit into from

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Aug 10, 2022

Similar approach as in #74

Will follow up with a changelog entry to master afterwards.

Fixes winit issue rust-windowing/winit#2415

CC @rib @maroider

@madsmtm madsmtm added the enhancement New feature or request label Aug 10, 2022
@madsmtm madsmtm changed the base branch from master to 0.4 August 10, 2022 17:50
@madsmtm
Copy link
Member Author

madsmtm commented Aug 10, 2022 •
edited

Ah no, of course we can't do it like this because I'm removing the blanket impls, and that's a breaking change, duh...

@madsmtm madsmtm mentioned this pull request Aug 10, 2022
Merged
5 tasks
@madsmtm madsmtm closed this Aug 10, 2022
@madsmtm madsmtm deleted the semver-trick-0-4 branch August 10, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@madsmtm