Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSRV policy regarding wasm-bindgen #162

Merged
merged 5 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ jobs:
rust-version: ${{ matrix.rust_version }}
- run: rustup target add wasm32-unknown-unknown

- name: Pin deps that break MSRV
if: matrix.rust_version == '1.64'
run: |
cargo update -p bumpalo --precise 3.14.0

- name: Check documentation
run: cargo doc --no-deps --document-private-items

Expand All @@ -51,4 +56,3 @@ jobs:

- name: Run tests for wasm32-unknown-unknown
run: cargo hack check --target wasm32-unknown-unknown --feature-powerset

11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,14 @@ raw window handle and display's platform-specific raw display handle. This does
not provide any utilities for creating and managing windows; instead, it
provides a common interface that window creation libraries (e.g. Winit, SDL)
can use to easily talk with graphics libraries (e.g. gfx-hal).

## MSRV Policy

The Minimum Safe Rust Version (MSRV) of this crate as of the time of writing is
**1.64.0**. For pre-`1.0` releases of `raw-window-handle`, this version will not
be changed without a patch bump to the version of `raw-window-handle`. After
version `1.0.0` is released, changes to the MSRV will necessitate a minor
version bump.

When the `wasm-bindgen-0-2` feature is enabled, the MSRV of this crate will be
raised to the MSRV of the latest version of `wasm-bindgen`.
Comment on lines +21 to +22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is good, because wasm-bingen still does not have an official MSRV policy.