Improve documentation for UIKit and AppKit handles #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
apple-handles-documentation
branch
from
aee40b9
to
51582c2
Compare
Lokathor
approved these changes
Feb 22, 2024
|
Other than the wasm CI failing, which I think is unrelated, it's always good to have usage example docs. |
Yeah, Winit had the same problem, not sure how |
|
Do we have a "wasm expert" to call for things like this? If |
|
That would be @daxpedda |
|
There is no good fix for this, this is a Cargo problem: rust-lang/rfcs#3537. The best we can do here, which we have done in Winit as well, is pin the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes part of the main thread only docs from #154, but with the less strong guarantee of the handle only ever existing on the main thread (as that's probably not yet true in the wild, so I'd rather have consumers to the extra check).