Skip to content

Commit

Permalink
ci: Add MSRV policy regarding wasm-bindgen
Browse files Browse the repository at this point in the history
wasm-bindgen recently bumped its MSRV to v1.73, which is much higher
than our MSRV of 1.64. Add an note to the README describing our MSRV
policy, and then test for it in CI.

Signed-off-by: John Nunley <dev@notgull.net>
  • Loading branch information
notgull committed Mar 5, 2024
1 parent 5e5dbed commit 41f014d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Expand Up @@ -41,6 +41,11 @@ jobs:
rust-version: ${{ matrix.rust_version }}
- run: rustup target add wasm32-unknown-unknown

- name: Pin deps that break MSRV
if: matrix.rust_version == '1.64'
run: |
cargo update -p bumpalo --precise 3.14.0
- name: Check documentation
run: cargo doc --no-deps --document-private-items

Expand All @@ -51,4 +56,3 @@ jobs:

- name: Run tests for wasm32-unknown-unknown
run: cargo hack check --target wasm32-unknown-unknown --feature-powerset

11 changes: 11 additions & 0 deletions README.md
Expand Up @@ -9,3 +9,14 @@ raw window handle and display's platform-specific raw display handle. This does
not provide any utilities for creating and managing windows; instead, it
provides a common interface that window creation libraries (e.g. Winit, SDL)
can use to easily talk with graphics libraries (e.g. gfx-hal).

## MSRV Policy

The Minimum Safe Rust Version (MSRV) of this crate as of the time of writing is
**1.64.0**. For pre-`1.0` releases of `raw-window-handle`, this version will not
be changed without a patch bump to the version of `raw-window-handle`. After
version `1.0.0` is released, changes to the MSRV will necessitate a minor
version bump.

When the `wasm-bindgen-0-2` feature is enabled, the MSRV of this crate will be
raised to the MSRV of the latest version of `wasm-bindgen`.

0 comments on commit 41f014d

Please sign in to comment.