Move to objc2
#1461
Merged
Move to objc2
#1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
|
Ah, you'd need a CI update for that? Could you also rebase? |
|
I moved the required MSRV bump to #1464 |
|
Will rebase after #1465 probably |
madsmtm
commented
Sep 17, 2022
4 tasks
|
I'm not sure how I should go forward with it, since the change is more or less stylistic right now. I'd wait for objc2 to release first. Don't want to release anything glutin with unstable crates. |
|
Fair - but then you should probably merge #1474 (otherwise |
|
Ah, I see, can't reopen though, should resend PR. |
|
@madsmtm would you mind updating the branch? I'm fine with having the same objc2 as in winit. |
|
Cool, I'll probably get to it at some point in the near future then |
This is a breaking change
In particular, this fixes: - UB in -[NSOpenGLPixelFormat getValues:forAttribute:forVirtualScreen:], cocoa mistakenly passed u64 where they should pass u32 - UB in -[NSOpenGLContext setValues:forParameter:], cocoa mistakenly passed u64 where they should pass usize - UB if -[NSOpenGLContext initWithFormat:shareContext:] returned NULL
|
Seems like nothing really changed, so rebase went without issues. |
kchibisov
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with following Cocoa's memory management rules (for example, #1453 wouldn't have happened with this) - and while I was at it, I fixed a few C
enumdefinitions (objc2'sverify_messagefeature is a great help with that).See commit messages for details.
CHANGELOG.mdif knowledge of this change could be valuable to users