Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix typo in item.rs #97

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Fix: fix typo in item.rs #97

merged 2 commits into from
Jun 21, 2020

Conversation

zhzy0077
Copy link
Contributor

Update 2 items:

  • Update the RFC number. It looks like a typo
  • Update the sample datetime to be a valid one.

Update 2 items:
- Update the RFC number. It looks like a typo
- Update the sample datetime to be a valid one.
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files          24       24           
  Lines        1724     1724           
=======================================
  Hits         1371     1371           
  Misses        353      353           
Impacted Files Coverage Δ
src/item.rs 81.10% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570c8da...bfc8131. Read the comment docs.

@andy128k
Copy link
Member

@zhzy0077 Technically RFC 822 is not a mistake. It is was superseded by RFC 2822.

Nice catch with a sample date. Could you also fix tests, which now fail?

@andy128k
Copy link
Member

LGTM

@andy128k andy128k merged commit 1b037d5 into rust-syndication:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants