Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fields public #94

Merged
merged 1 commit into from
Jun 8, 2020
Merged

make fields public #94

merged 1 commit into from
Jun 8, 2020

Conversation

AnderEnder
Copy link
Contributor

@AnderEnder AnderEnder commented Jun 7, 2020

Closes #71

@AnderEnder AnderEnder requested a review from andy128k June 7, 2020 16:43
@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files          24       24           
  Lines        1724     1724           
=======================================
  Hits         1371     1371           
  Misses        353      353           
Impacted Files Coverage Δ
src/category.rs 91.66% <ø> (ø)
src/channel.rs 79.28% <ø> (ø)
src/cloud.rs 86.66% <ø> (ø)
src/enclosure.rs 87.87% <ø> (ø)
src/extension/dublincore.rs 59.09% <ø> (ø)
src/extension/itunes/itunes_category.rs 100.00% <ø> (ø)
src/extension/itunes/itunes_channel_extension.rs 82.66% <ø> (ø)
src/extension/itunes/itunes_item_extension.rs 85.50% <ø> (ø)
src/extension/itunes/itunes_owner.rs 100.00% <ø> (ø)
src/extension/mod.rs 71.42% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2663695...5f0a476. Read the comment docs.

@AnderEnder AnderEnder changed the title make api public close #71 make api public Jun 7, 2020
@AnderEnder AnderEnder changed the title close #71 make api public close#71 make api public Jun 7, 2020
@AnderEnder AnderEnder changed the title close#71 make api public make api public Jun 7, 2020
@andy128k andy128k changed the title make api public make fields public Jun 7, 2020
@andy128k andy128k merged commit 276459a into master Jun 8, 2020
@andy128k andy128k deleted the public-api branch June 8, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making fields public
2 participants