Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped quick_xml::error in a new type to hide quick_xml #65

Merged
merged 4 commits into from Jul 10, 2022

Conversation

Ochism
Copy link

@Ochism Ochism commented May 17, 2022

Should close #62
Though I wonder if ToXml's return of quick_xml::Error might also need to be removed

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #65 (33f939f) into master (9956e1b) will decrease coverage by 4.52%.
The diff coverage is 60.38%.

❗ Current head 33f939f differs from pull request most recent head 02d8dbe. Consider uploading reports for the commit 02d8dbe to get more accurate results

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   85.08%   80.56%   -4.53%     
==========================================
  Files          19       19              
  Lines        1301     1415     +114     
==========================================
+ Hits         1107     1140      +33     
- Misses        194      275      +81     
Impacted Files Coverage Δ
src/error.rs 0.00% <0.00%> (ø)
src/extension/util.rs 75.92% <40.00%> (-17.41%) ⬇️
src/text.rs 67.90% <44.00%> (-12.10%) ⬇️
src/entry.rs 75.20% <50.00%> (-4.80%) ⬇️
src/person.rs 71.42% <50.00%> (-9.13%) ⬇️
src/source.rs 71.81% <50.00%> (-5.33%) ⬇️
src/toxml.rs 78.57% <50.00%> (-9.43%) ⬇️
src/feed.rs 79.26% <57.14%> (-4.74%) ⬇️
src/extension/mod.rs 70.96% <66.66%> (-5.04%) ⬇️
src/generator.rs 79.06% <70.58%> (-8.03%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9956e1b...02d8dbe. Read the comment docs.

@andy128k andy128k mentioned this pull request Jul 4, 2022
@andy128k andy128k merged commit dd46a0f into rust-syndication:master Jul 10, 2022
@Ochism Ochism deleted the no-more-quick-xml branch July 21, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error exposes quick_xml::Error in the public API
2 participants