Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust toolchain to 1.70.0 #874

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

widagdos
Copy link
Contributor

@widagdos widagdos commented Mar 24, 2024

Since we are not using exact version of dependencies, some of our dependencies have been updated to require rust 1.70.0.

This commit update our toolchain to match that requirement.

Current error message on the master branch on 1.66.0:

cargo +1.66.0 clippy --all-targets -- -D warnings
error: package `toml v0.8.12` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.66.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p toml@0.8.12 --precise ver
where `ver` is the latest version of `toml` supporting rustc 1.66.0

src/prop_name.rs is changed to address the following clippy error message

error: this could be rewritten as `let...else`
  --> src/prop_name.rs:20:9
   |
20 | /         let bytes = if let Some((&0, bytes)) = value.as_bytes().split_last() {
21 | |             bytes
22 | |         } else {
23 | |             panic!("input was not nul-terminated");
24 | |         };
   | |__________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else
   = note: `-D clippy::manual-let-else` implied by `-D warnings`
help: consider writing
   |
20 ~         let Some((&0, bytes)) = value.as_bytes().split_last() else {
21 +             panic!("input was not nul-terminated");
22 +         };
   |

Since we are not using exact version of dependencies, some of our dependencies have been updated to require rust 1.70.0.

This commit update our toolchain to match that requirement.

Current error message on the `master` branch on 1.66.0:
```
cargo +1.66.0 clippy --all-targets -- -D warnings
error: package `toml v0.8.12` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.66.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p toml@0.8.12 --precise ver
where `ver` is the latest version of `toml` supporting rustc 1.66.0
```
@aleksuss aleksuss merged commit b7f2f3b into rust-rocksdb:master Apr 25, 2024
7 checks passed
@widagdos widagdos deleted the update-ro-rust-1.70.0 branch April 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants