Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose LRU and blob cache options #837

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

athre0z
Copy link

@athre0z athre0z commented Nov 25, 2023

@athre0z athre0z changed the title Expose blob cache options Expose LRU and blob cache options Nov 26, 2023
@athre0z
Copy link
Author

athre0z commented Nov 26, 2023

Added one more commit to also expose the advanced LRU cache constructor with custom options.

@aleksuss
Copy link
Member

aleksuss commented Dec 14, 2023

@athre0z overall looks good, but could you add some tests, please?

@zaidoon1
Copy link
Contributor

This also LGTM, adding tests would be great

@athre0z
Copy link
Author

athre0z commented Jan 23, 2024

I can write some tests, but it might take a while until I get to it depending on how deep these tests should go: I'm unfortunately rather short on time right now. Simply adding tests that invoke the new methods to make sure it links & doesn't segfault is quickly done, but I might have to read up a bit deeper if you'd like tests that actually make sure that RocksDB is caching things as expected etc (like some other test cases seem to do). What's the expectation here?

@zaidoon1
Copy link
Contributor

I can write some tests, but it might take a while until I get to it depending on how deep these tests should go: I'm unfortunately rather short on time right now. Simply adding tests that invoke the new methods to make sure it links & doesn't segfault is quickly done, but I might have to read up a bit deeper if you'd like tests that actually make sure that RocksDB is caching things as expected etc (like some other test cases seem to do). What's the expectation here?

a simple test case where you set the new options being exposed here, and put some kvs without segfaulting is good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants