Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UTF-8 file paths on Windows #551

Merged
merged 2 commits into from Sep 3, 2021
Merged

Support UTF-8 file paths on Windows #551

merged 2 commits into from Sep 3, 2021

Conversation

rajivshah3
Copy link
Contributor

This re-adds support for UTF-8 file paths on Windows, which was removed in #493

Fixes #512
Fixes #85 (already closed)

@rajivshah3 rajivshah3 mentioned this pull request Aug 25, 2021
Closed
stanislav-tkach
stanislav-tkach approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, previously the ROCKSDB_WINDOWS_UTF8_FILENAMES option was set and now you have added the different (WITH_WINDOWS_UTF8_FILENAMES) option. Are the any differences between them?

@rajivshah3
Copy link
Contributor Author

@stanislav-tkach sorry, I forgot to clarify that. I think they're basically the same — setting WITH_WINDOWS_UTF8_FILENAMES to ON adds the -DROCKSDB_WINDOWS_UTF8_FILENAMES flag (https://github.com/facebook/rocksdb/blob/8608d75d85f8e1b3b64b73a4fb6d19baec61ba5c/CMakeLists.txt#L69-L72). I can change this if you'd like

@aleksuss aleksuss merged commit e2e8834 into rust-rocksdb:master Sep 3, 2021
@rajivshah3 rajivshah3 deleted the fix/win-utf8-paths branch September 6, 2021 19:13
@rajivshah3
Copy link
Contributor Author

Thanks @stanislav-tkach @aleksuss ! Would it be possible to make a new release with these changes? We'd like to use this fix and a few others in our projects

@rajivshah3 rajivshah3 mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislav-tkach stanislav-tkach stanislav-tkach approved these changes

@aleksuss aleksuss aleksuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode path names issue on Windows reappeared [Windows] Unicode path issue
3 participants
@rajivshah3 @stanislav-tkach @aleksuss