Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AsByteSliceMut with Fill #940

Merged
merged 5 commits into from Mar 9, 2020
Merged

Replace AsByteSliceMut with Fill #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6403c10
Move Rng trait to sub-module
dhardy Feb 28, 2020
571c9af
Misc bench: add gen_1kb_u16_*
dhardy Feb 28, 2020
7bdfa85
Replace AsByteSliceMut with Fill
dhardy Feb 28, 2020
eccd1f8
Optimise: avoid inlining
dhardy Feb 28, 2020
d66d4d1
Impl Fill for slices over bool, char, f32, f64
dhardy Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
51 changes: 47 additions & 4 deletions benches/misc.rs
View file
Open in desktop
Expand Up @@ -97,7 +97,50 @@ fn misc_bernoulli_var(b: &mut Bencher) {
}

#[bench]
fn gen_1k_iter_repeat(b: &mut Bencher) {
fn gen_1kb_u16_iter_repeat(b: &mut Bencher) {
use std::iter;
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
b.iter(|| {
let v: Vec<u16> = iter::repeat(()).map(|()| rng.gen()).take(512).collect();
v
});
b.bytes = 1024;
}

#[bench]
fn gen_1kb_u16_sample_iter(b: &mut Bencher) {
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
b.iter(|| {
let v: Vec<u16> = Standard.sample_iter(&mut rng).take(512).collect();
v
});
b.bytes = 1024;
}

#[bench]
fn gen_1kb_u16_gen_array(b: &mut Bencher) {
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
b.iter(|| {
// max supported array length is 32!
let v: [[u16; 32]; 16] = rng.gen();
v
});
b.bytes = 1024;
}

#[bench]
fn gen_1kb_u16_fill(b: &mut Bencher) {
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
let mut buf = [0u16; 512];
b.iter(|| {
rng.fill(&mut buf[..]);
buf
});
b.bytes = 1024;
}

#[bench]
fn gen_1kb_u64_iter_repeat(b: &mut Bencher) {
use std::iter;
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
b.iter(|| {
Expand All @@ -108,7 +151,7 @@ fn gen_1k_iter_repeat(b: &mut Bencher) {
}

#[bench]
fn gen_1k_sample_iter(b: &mut Bencher) {
fn gen_1kb_u64_sample_iter(b: &mut Bencher) {
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
b.iter(|| {
let v: Vec<u64> = Standard.sample_iter(&mut rng).take(128).collect();
Expand All @@ -118,7 +161,7 @@ fn gen_1k_sample_iter(b: &mut Bencher) {
}

#[bench]
fn gen_1k_gen_array(b: &mut Bencher) {
fn gen_1kb_u64_gen_array(b: &mut Bencher) {
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
b.iter(|| {
// max supported array length is 32!
Expand All @@ -129,7 +172,7 @@ fn gen_1k_gen_array(b: &mut Bencher) {
}

#[bench]
fn gen_1k_fill(b: &mut Bencher) {
fn gen_1kb_u64_fill(b: &mut Bencher) {
let mut rng = Pcg64Mcg::from_rng(&mut thread_rng()).unwrap();
let mut buf = [0u64; 128];
b.iter(|| {
Expand Down