Prepare rand_chacha 0.2.1 #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
vks
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Looks good to me! The README suggests the feature only includes some unsafe code, so hopefully it does not break on platforms without SIMD.
|
Hmm, it would be nice if instead we could provide an opt-in feature to disable a default feature, but this isn't how Cargo works. My understanding from what @kazcw said previously is that we should not need to disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kazcw I believe we can do this? (Complementary changes are in #844.)