Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ChaCha20 in StdRng and feature-gate SmallRng #792

Merged
merged 7 commits into from Jun 3, 2019
Merged

Use ChaCha20 in StdRng and feature-gate SmallRng #792

merged 7 commits into from Jun 3, 2019

Commits on Jun 3, 2019

  1. rand_distr: switch test RNG to Pcg32, update vectors and tweak Cauchy… 

    … test

We want a value-stable RNG to avoid future vector changes
which means using something outside of Rand. Pcg32 is a good
fit and is easy to embed if that is ever necessary.
    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    917d67b View commit details
    Browse the repository at this point in the history

  2. Switch Rand's test::rng to Pcg32 

    seq::test::test_slice_choose updated with better bounds
    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    efd3b5c View commit details
    Browse the repository at this point in the history

  3. Update features doc

    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    1ea01ae View commit details
    Browse the repository at this point in the history

  4. Feature-gate the SmallRng generator

    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    b7abfb6 View commit details
    Browse the repository at this point in the history

  5. Enable small_rng feature requirement for each benchmark 

    Not ideal but seems to work; see: rust-lang/cargo#6945
    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    41b9743 View commit details
    Browse the repository at this point in the history

  6. Replace StdRng algorithm with ChaCha20 and adjust reseeding threshold

    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    33bd404 View commit details
    Browse the repository at this point in the history

  7. Use Hc128 on Emscripten 

    This is considered an ugly hack, but easier than making the new ChaChaRng
compatible with Emscripten. Potentially support for Emscripten will be dropped
in the future, if it doesn't get support for u128.
    @dhardy
    dhardy committed Jun 3, 2019
    Copy the full SHA
    ff121cf View commit details
    Browse the repository at this point in the history