Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniform sampling: use Canon's method #1287

Merged
merged 10 commits into from
Mar 24, 2023
Merged

Uniform sampling: use Canon's method #1287

merged 10 commits into from
Mar 24, 2023

Commits on Feb 17, 2023

  1. Add uniform distribution benchmarks 

    Based on canon-uniform-benches branch, revised
    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8cf5972 View commit details
    Browse the repository at this point in the history

  2. Uniform: use sampling methods from canon-uniform-benches branch 

    Also: add "unbiased" feature flag
    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    c12bddb View commit details
    Browse the repository at this point in the history

  3. Fix feature simd_support

    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    9d2c5fa View commit details
    Browse the repository at this point in the history

  4. Update value stability tests

    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    09df9da View commit details
    Browse the repository at this point in the history

  5. Add line to CHANGELOG

    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    cb953e4 View commit details
    Browse the repository at this point in the history

  6. Uniform SIMD sampling: use Lemire's method 

    This is a small tweak unsupported by evidence, but brings
SIMD in line with unbiased integer range sampling.
    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8dc7f79 View commit details
    Browse the repository at this point in the history

  7. Uniform: impl PartialEq, Eq where possible 

    Allows simpler tests
    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    202d840 View commit details
    Browse the repository at this point in the history

  8. CI: benches now require small_rng; build-test unbiased 

    Note: unbiased does pass current value-stability tests,
but could fail extra ones in the future.
    @dhardy
    dhardy committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    777d9e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Always use Lemire's method for distribution sampling

    @dhardy
    dhardy committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    6d5f123 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Address review

    @dhardy
    dhardy committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e2148da View commit details
    Browse the repository at this point in the history