Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #1177

Closed
wants to merge 2 commits into from
Closed

Update changelog #1177

wants to merge 2 commits into from

Conversation

vks
Copy link
Collaborator

@vks vks commented Sep 10, 2021

Also fix a clippy warning about tabs in comments.

Comment on lines 42 to +45
/// [A Method to Simulate the Skew Normal Distribution]:
/// Ghorbanzadeh, D. , Jaupi, L. and Durand, P. (2014)
/// [A Method to Simulate the Skew Normal Distribution](https://dx.doi.org/10.4236/am.2014.513201).
/// Applied Mathematics, 5, 2073-2076.
/// Ghorbanzadeh, D. , Jaupi, L. and Durand, P. (2014)
/// [A Method to Simulate the Skew Normal Distribution](https://dx.doi.org/10.4236/am.2014.513201).
/// Applied Mathematics, 5, 2073-2076.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of reference works?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the cargo doc output, so I'm not sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it doesn't:
grafik

@dhardy
Copy link
Member

dhardy commented Sep 11, 2021

Why does this miss stuff you added in #1160?

@vks
Copy link
Collaborator Author

vks commented Sep 11, 2021

Because #1160 is not yet merged. But you are right, there is some duplication. I might just merge this branch into #1160.

@vks
Copy link
Collaborator Author

vks commented Sep 11, 2021

Closed in favor of #1160.

@vks vks closed this Sep 11, 2021
@vks vks deleted the fix-clippy branch September 11, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants