Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_const_gen to "all stable features" test invocation #1175

Merged
merged 2 commits into from Sep 10, 2021
Merged

Add min_const_gen to "all stable features" test invocation #1175

merged 2 commits into from Sep 10, 2021

Conversation

connec
Copy link
Contributor

@connec connec commented Sep 10, 2021

I was in the process of making a PR to support min_const_gen without std when I saw #1173 already existed! This PR is intended to unblock/accelerate that, though it makes sense as an orthogonal change. If it's preferable to fix it in that PR, feel free to close this one 馃檪


`min_const_gen` is a stable feature, but was not added to this test
invocation when it was introduced.

Unblocks #1173.
@vks
Copy link
Collaborator

vks commented Sep 10, 2021

Unfortunately, this also runs this feature on Rust 1.36, which does not support const generics yet.

Since const generics are not stable in Rust 1.36.0, we cannot use the
`min_const_gen` feature when testing the MSRV.
@connec
Copy link
Contributor Author

connec commented Sep 10, 2021

Good point! I've pushed a new commit, splitting out the 'all features' test into two conditional steps, one for MSRV and one for non-MSRV.

I thought to deduplicate the 1.36.0 literal, but GitHub Actions only supports doing so using environment variables, e.g.

env:
    MSRV: 1.36.0
...
toolchain: ${{ env.MSRV }}
...
if: ${{ matrix.toolchain }} != ${{ env.MSRV }}

However I didn't like the idea of using environment variables for that, lest they interfere with something. Happy to apply it though if you don't think it's a concern.

@vks
Copy link
Collaborator

vks commented Sep 10, 2021

Thanks! Your change looks good, it's the same approach we are using for nightly.

@vks vks merged commit 0932a58 into rust-random:master Sep 10, 2021
@connec connec deleted the stable-test-all-features branch September 11, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants