Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no_std compatibility issues #1173

Merged
merged 5 commits into from Sep 10, 2021
Merged

Fix no_std compatibility issues #1173

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1544c72
fix no_std/alloc/std compatibility issues
bhgomes Sep 4, 2021
f5cfbc4
revert sample_efraimidis_spirakis and fix suggestions
bhgomes Sep 6, 2021
6d4baef
move min_const_gen test to nightly workflow
bhgomes Sep 6, 2021
f7f9287
Merge branch 'stable-test-all-features' into no-std-fix
vks Sep 10, 2021
2bddede
Merge branch 'master' into no-std-fix
vks Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -77,11 +77,12 @@ jobs:
cargo test --target ${{ matrix.target }} --all-features
cargo test --target ${{ matrix.target }} --benches --features=nightly
cargo test --target ${{ matrix.target }} --manifest-path rand_distr/Cargo.toml --benches
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features min_const_gen
- name: Test rand
run: |
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features
cargo build --target ${{ matrix.target }} --no-default-features --features alloc,getrandom,small_rng,min_const_gen
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features=alloc,getrandom,small_rng,min_const_gen
cargo build --target ${{ matrix.target }} --no-default-features --features alloc,getrandom,small_rng
cargo test --target ${{ matrix.target }} --lib --tests --no-default-features --features=alloc,getrandom,small_rng
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't min_const_gen work on stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would, but I was getting errors in the CI, but perhaps they were other kinds of errors. I don't have a good way to test the CI, so maybe one of the maintainers should put the flag in the right place.

# all stable features:
cargo test --target ${{ matrix.target }} --features=serde1,log,small_rng
cargo test --target ${{ matrix.target }} --examples
Expand Down