Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1082 (seed_from_u64 with non multiple of 4) #1083

Merged
merged 2 commits into from Jan 4, 2021
Merged

Fix #1082 (seed_from_u64 with non multiple of 4) #1083

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb4b8a4
Fix #1082 (seed_from_u64 with non multiple of 4)
dhardy Jan 1, 2021
594aed8
seed_from_u64: use newpavlov's suggestion
dhardy Jan 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion rand_core/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -4,7 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.6.1] - 2020-12-31
## [0.6.1] - 2021-01-03
### Fixed
- Avoid panic when using `RngCore::seed_from_u64` with a seed which is not a
multiple of four (#1082)
### Other
- Enable all stable features in the playground (#1081)

Expand Down
2 changes: 1 addition & 1 deletion rand_core/src/lib.rs
View file
Open in desktop
Expand Up @@ -313,7 +313,7 @@ pub trait SeedableRng: Sized {
let xorshifted = (((state >> 18) ^ state) >> 27) as u32;
let rot = (state >> 59) as u32;
let x = xorshifted.rotate_right(rot);
chunk.copy_from_slice(&x.to_le_bytes());
chunk.copy_from_slice(&x.to_le_bytes()[..chunk.len()]);
}

Self::from_seed(seed)
Expand Down