Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chacha performance #1023

Merged
merged 1 commit into from Aug 28, 2020
Merged

Fix chacha performance #1023

merged 1 commit into from Aug 28, 2020

Conversation

vks
Copy link
Collaborator

@vks vks commented Aug 24, 2020 •
edited

This reverts a change from #979 that introduced a massive performance regression by disabling SIMD for rand_chacha.

Likely, the behavior of ppv-lite86 should rather be fixed (cryptocorrosion/cryptocorrosion#35). This change serves as a workaround until a fixed version is available.

Fixes #1017.

cc @kazcw

@vks
Fix chacha performance
ad2ea0a 
This reverts a change from rust-random#979 that introduced a massive performance
regression by disabling SIMD for `rand_chacha`.

Likely, the behavior of `ppv-lite86` should rather be fixed. This change
serves as a workaround until a fixed version is available.

Fixes rust-random#1017.
@dhardy
Copy link
Member

dhardy commented Aug 26, 2020

The last rand_chacha release is 0.2.2 which is before #979, so this doesn't affect a release version. Given that, we should wait a little while at least for @kazcw to respond.

@vks
Copy link
Collaborator Author

vks commented Aug 26, 2020

Fair enough, we can defer merging this until either ppv-lite86 is fixed and this PR becomes obsolete or until the next rand_chacha version is released.

dhardy
dhardy approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ppv-lite86 is not a public dependency, so there's no harm in merging this now @kazcw releasing v0.3 of ppv-lite86 which we can switch to with a patch release.

@vks vks merged commit fbcfa22 into rust-random:master Aug 28, 2020
@vks vks deleted the fix-chacha-perf branch August 28, 2020 16:07
@dhardy dhardy mentioned this pull request Dec 7, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simd not used for rand_chacha
2 participants
@vks @dhardy