Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: weighted sampling without replacement #1013

Merged
merged 11 commits into from Aug 27, 2020
Merged

Re: weighted sampling without replacement #1013

merged 11 commits into from Aug 27, 2020

Commits on Aug 27, 2020

  1. Add choose_multiple_weighted, tests, and benchmarks

    @zrneely @vks
    zrneely authored and vks committed Aug 27, 2020
    Copy the full SHA
    ca7de51 View commit details
    Browse the repository at this point in the history

  2. Mark new tests with the correct feature flags

    @zrneely @vks
    zrneely authored and vks committed Aug 27, 2020
    Copy the full SHA
    5144b23 View commit details
    Browse the repository at this point in the history

  3. Fix feature flags and use core for nostd compatibility

    @zrneely @vks
    zrneely authored and vks committed Aug 27, 2020
    Copy the full SHA
    512e2dd View commit details
    Browse the repository at this point in the history

  4. Don't use rustc features newer than 1.32

    @zrneely @vks
    zrneely authored and vks committed Aug 27, 2020
    Copy the full SHA
    33bb79a View commit details
    Browse the repository at this point in the history

  5. Don't use IntoIter when unnecessary and fix complexity documentation

    @zrneely @vks
    zrneely authored and vks committed Aug 27, 2020
    Copy the full SHA
    6751c9b View commit details
    Browse the repository at this point in the history

  6. Undo reformatting

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    dadaae6 View commit details
    Browse the repository at this point in the history

  7. sample_weighted: Return early if amount is 0

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    51f2861 View commit details
    Browse the repository at this point in the history

  8. Address review feedback

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    6d922a0 View commit details
    Browse the repository at this point in the history

  9. sample_weighted: Use less memory for length <= u32::MAX

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    cb021c5 View commit details
    Browse the repository at this point in the history

  10. Get rid of "partition_add_index" feature 

    It offers nothing over the "nightly" feature and makes testing more
complicated.
    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    03bd82a View commit details
    Browse the repository at this point in the history

  11. sample_weighted: Make sure the correct IndexVec is generated 

    Also add some tests.
    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    d73eac5 View commit details
    Browse the repository at this point in the history