Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.36 #1011

Merged
merged 17 commits into from Aug 28, 2020
Merged

Bump MSRV to 1.36 #1011

merged 17 commits into from Aug 28, 2020

Commits on Aug 27, 2020

  1. Bump MSRV to 1.36

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    8057576 View commit details
    Browse the repository at this point in the history

  2. Reenable alloc tests for MSRV

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    eef82c4 View commit details
    Browse the repository at this point in the history

  3. Drop some unsafe code from rand_core 

    The necessary standard library functions were stabilized with Rust 1.34.
Our MSRV is 1.36.
    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    0432b06 View commit details
    Browse the repository at this point in the history

  4. Avoid indexing

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    afc6bc6 View commit details
    Browse the repository at this point in the history

  5. Simplify cfg logic 

    This is possible thanks to `alloc` being implied by `std` builds since
Rust 1.36.
    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    f4746e1 View commit details
    Browse the repository at this point in the history

  6. Try to fix endianess issue

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    6911b8f View commit details
    Browse the repository at this point in the history

  7. Simplify tests to address review feedback

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    514e60d View commit details
    Browse the repository at this point in the history

  8. WeightedIndex: Fix serde test

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    e97a7e6 View commit details
    Browse the repository at this point in the history

  9. Fix fill_via_chunks and add tests

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    73422d3 View commit details
    Browse the repository at this point in the history

  10. Simplify macro

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    6e27f41 View commit details
    Browse the repository at this point in the history

  11. Use chunks_exact_mut for slightly better performance 

    The results from master, using unsafe code:
```
gen_bytes_chacha12:   2,733,838 ns/iter (+/- 181,694) = 374 MB/s
gen_bytes_chacha20:   4,339,602 ns/iter (+/- 237,793) = 235 MB/s
gen_bytes_chacha8:    1,918,279 ns/iter (+/- 103,581) = 533 MB/s
```

The results of the new code using `chunks_exact_mut` (this commit):
```
gen_bytes_chacha12:   3,049,147 ns/iter (+/- 220,631)   = 335 MB/s
gen_bytes_chacha20:   4,645,772 ns/iter (+/- 269,261)   = 220 MB/s
gen_bytes_chacha8:    2,214,954 ns/iter (+/- 1,745,600) = 462 MB/s
```

The results of using `chunks_mut` (before this commit):
```
gen_bytes_chacha12:   3,492,109 ns/iter (+/- 164,638) = 293 MB/s
gen_bytes_chacha20:   5,087,706 ns/iter (+/- 249,219) = 201 MB/s
gen_bytes_chacha8:    2,700,197 ns/iter (+/- 524,148) = 379 MB/s
```
    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    e40851a View commit details
    Browse the repository at this point in the history

  12. Check source size and prefer chunks_exact

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    23e02db View commit details
    Browse the repository at this point in the history

  13. Simplify code

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    d74e800 View commit details
    Browse the repository at this point in the history

  14. Restore unsafe fill_via_chunks implementation for performance

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    422bb44 View commit details
    Browse the repository at this point in the history

  15. Delete dead code

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    11439b5 View commit details
    Browse the repository at this point in the history

  16. Slightly improve test

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    0913bc7 View commit details
    Browse the repository at this point in the history

  17. Update changelog

    @vks
    vks committed Aug 27, 2020
    Copy the full SHA
    2bc54d0 View commit details
    Browse the repository at this point in the history