Skip to content

Commit

Permalink
Fix some minor clippy warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
vks committed Jul 31, 2020
1 parent cc2e7dd commit 28bf11d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 17 deletions.
2 changes: 1 addition & 1 deletion src/distributions/weighted_index.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ impl<X: SampleUniform + PartialOrd> WeightedIndex<X> {
if !(*w >= zero) {
return Err(WeightedError::InvalidWeight);
}
if i >= self.cumulative_weights.len() + 1 {
if i > self.cumulative_weights.len() {
return Err(WeightedError::TooMany);
}

Expand Down
5 changes: 2 additions & 3 deletions src/rngs/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,12 @@ impl RngCore for StepRng {

#[cfg(test)]
mod tests {
use super::*;

#[test]
#[cfg(feature = "serde1")]
fn test_serialization_step_rng() {
let some_rng = StepRng::new(42, 7);
let de_some_rng: StepRng = bincode::deserialize(&bincode::serialize(&some_rng).unwrap()).unwrap();
let de_some_rng: StepRng =
bincode::deserialize(&bincode::serialize(&some_rng).unwrap()).unwrap();
assert_eq!(some_rng.v, de_some_rng.v);
assert_eq!(some_rng.a, de_some_rng.a);

Expand Down
22 changes: 9 additions & 13 deletions src/seq/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,11 @@ use crate::Rng;
/// ```
/// use rand::seq::SliceRandom;
///
/// fn main() {
/// let mut rng = rand::thread_rng();
/// let mut bytes = "Hello, random!".to_string().into_bytes();
/// bytes.shuffle(&mut rng);
/// let str = String::from_utf8(bytes).unwrap();
/// println!("{}", str);
/// }
/// let mut rng = rand::thread_rng();
/// let mut bytes = "Hello, random!".to_string().into_bytes();
/// bytes.shuffle(&mut rng);
/// let str = String::from_utf8(bytes).unwrap();
/// println!("{}", str);
/// ```
/// Example output (non-deterministic):
/// ```none
Expand Down Expand Up @@ -228,12 +226,10 @@ pub trait SliceRandom {
/// ```
/// use rand::seq::IteratorRandom;
///
/// fn main() {
/// let mut rng = rand::thread_rng();
///
/// let faces = "πŸ˜€πŸ˜ŽπŸ˜πŸ˜•πŸ˜ πŸ˜’";
/// println!("I am {}!", faces.chars().choose(&mut rng).unwrap());
/// }
/// let mut rng = rand::thread_rng();
///
/// let faces = "πŸ˜€πŸ˜ŽπŸ˜πŸ˜•πŸ˜ πŸ˜’";
/// println!("I am {}!", faces.chars().choose(&mut rng).unwrap());
/// ```
/// Example output (non-deterministic):
/// ```none
Expand Down

0 comments on commit 28bf11d

Please sign in to comment.