Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_file: Remove use of spin-locks #125

Merged
merged 3 commits into from Jan 7, 2020
Merged

use_file: Remove use of spin-locks #125

merged 3 commits into from Jan 7, 2020

Commits on Jan 6, 2020

  1. util_libc: open_readonly shoud return a Result 

    Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    3fdeab7 View commit details
    Browse the repository at this point in the history

  2. use_file: Remove use of spin-locks 

    Don't spin when polling /dev/random. We also remove the use of spin
locks when opening the persistent fd for platforms that require it.

For both these cases, we can just use the pthread lock/unlock methods
in libc. This includes adding Mutex and DropGuard abstractions.

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    fd7677e View commit details
    Browse the repository at this point in the history

  3. util: Remove unused spin-lock interfaces 

    We no longer use spin-locks anywhere in getrandom, so remove any
interfaces which spin.

Signed-off-by: Joe Richey <joerichey@google.com>
    @josephlr
    josephlr committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    d728d5b View commit details
    Browse the repository at this point in the history