Update ctor #117
Closed
Update ctor #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly to remove syn 1 from my dependency tree. This increases MSRV to 1.56, so I updated the test matrix. MSRV in README seemed to be outdated so I removed that and added it to Cargo.toml instead.
|
Hi, thanks for the contribution! There is already a PR in flight to replace However, both changes IMO are blocked on being tested in a Windows environment. The Windows CI environment is not suitable to test these changes (you can currently remove all the ctor code and it still passes). So , happy to look further at this, if you are able to test on a Windows environment? |
|
I do have a Windows computer I can test with. I’ll check out the once version and let you know |
|
ctor has been removed in v1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly to remove syn 1 from my dependency tree. This increases MSRV to 1.56, so I updated the test matrix. MSRV in README seemed to be outdated so I removed that and added it to Cargo.toml instead.
I also noticed CI warnings about the deprecated
set-outputsyntax, so just a heads up that that needs updating.