Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade ctor to 0.2.0 #108

Closed

Conversation

audunhalland
Copy link

ctor released version 0.2.0 which bumps the syn version to 2.x. Not sure why ctor needed to bump to a non-backwards-compatible release. There doesn't seem to be any other changes than just internal dependency upgrades.

@tommilligan
Copy link
Collaborator

Hi @audunhalland, thanks for picking this up. There's a failure in the Windows CI indicating this is a breaking change somehow - I'm not sure what the context really is, can you offer any insight?

I'm open to the CI being updated as well, as it's pretty old at this point.

@audunhalland
Copy link
Author

Unfortunately I don't use windows :(

I was just looking at my lock file trying to phase out various uses of syn 1.x.

@tommilligan
Copy link
Collaborator

Ah okay. I mean if you don't use Windows, you won't end up compiling syn 1.x anyway, though I agree it's nice to keep things up to date.

I had a dig into why we even use ctor and what it does, IMO it's actually not a nice solution and we could replace it with something like once_cell at runtime. However, as I also don't use windows/powershell, I'm inclined to not touch it for now until someone who does use Windows complains at me.

Closing unless further interested is expressed from Windows users

@tommilligan
Copy link
Collaborator

ctor has been removed in v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants