Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: remove stale vt100/ctor dependencies
- Loading branch information
1 parent
26bd02f
commit 3f07591
Showing
2 changed files
with
0 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f07591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really a stale dependency? As far as I understand, it enables ANSI escaped characters on Windows so that Command Line or Power Shell can use colors and formatting (e.g. bold font).
3f07591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohnScience there was some discussion around this, and we could not reproduce a failure so elected to remove the dependencies. If users report a failing environment, we can then decide whether to support it or not.
Having said all that, I do see that popular tools like
ripgrep
do still have some windows specific logic (i.e. usetermcolor
library, which handles this for you internally). I'd be up for migrating our printing internals fromyansi
totermcolor
if that would give wider compatibilityhttps://github.com/BurntSushi/ripgrep/blob/efb2e8ce1e1277fbfa37329b6663c8cf86d6951a/crates/printer/src/color.rs#L5
3f07591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in #120