Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FusedIterator and ExactSizeIterator where possible #159

Merged
merged 1 commit into from Jun 9, 2021

Conversation

lopopolo
Copy link
Contributor

@lopopolo lopopolo commented Mar 4, 2021

Also add Iterator::count impls where Iterator::size_hint was already implemented to return (n, Some(n)).

I'd find these impls useful as I implement my own wrapper iterators around these iterators in a new crate I'm working on that implements a Ruby Regexp with multiple regex backends, one of which is onig.

I've done similar work in regex: rust-lang/regex#734.

Also add `Iterator::count` impls where `Iterator::size_hint` was already
implemented to return `(n, Some(n))`.
Copy link
Collaborator

@iwillspeak iwillspeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@iwillspeak iwillspeak merged commit 7d29d76 into rust-onig:main Jun 9, 2021
@lopopolo lopopolo deleted the iter-fused branch November 21, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants