Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BITS associated constant to PrimInt #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

umanwizard
Copy link

No description provided.

@cuviper
Copy link
Member

cuviper commented Oct 19, 2022

Unfortunately, this is a breaking change for external implementors, especially since this trait isn't sealed.

It's tempting to add a default to 8 * mem::size_of::<Self>(), but nothing says that the entire value has to be numeric bits either. It could be a wrapper with some other extraneous metadata, for example.

#247 suggests a new trait, which would avoid a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants