add try from methods #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vks
reviewed
Feb 4, 2021
| @@ -16,7 +16,8 @@ edition = "2018" | |||
| [package.metadata.docs.rs] | |||
| features = ["std", "num-bigint-std", "serde"] | |||
|
|
|||
| [dependencies] | |||
| [dependencies.paste] | |||
| version = "1.0" | |||
There was a problem hiding this comment.
Why is this dependency required?
There was a problem hiding this comment.
its for generating the call to the corresponding underlying impl ::[<from_ $name>]
fn try_from(n: $name) -> Result<Self, ()> {
<$into as FromPrimitive>::[<from_ $name>](n)
.map(Ratio::from_integer)
.ok_or(())
}
|
As far as I can see, this does not include any new tests for the added functionality. |
Yes, I was unsure how much this should be tested, maybe a few lines which check the Ok and Error case would be fine because it does not really add anything, just exposes existing functionality differently. I was using this as a fork and also needed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in #85
I went ahead and implemented From and TryFrom for all applicable types, not just floats.
This is a more detailed approach than the current FromPrimitive Trait which always returns an Option but some conversions can never fail so we can unwrap them.