Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Integer::divides as deprecated. #42

Merged
merged 2 commits into from Feb 8, 2024
Merged

Conversation

aobatact
Copy link
Contributor

Resolves #41.

@cuviper
Copy link
Member

cuviper commented Apr 28, 2021

Hey, congrats, you're the first contributor that I've had to manually approve for GitHub Actions. :/

But I expect this will fail on older Rust, since this crates tests all the way back to 1.8, and #[deprecated] wasn't stabilized until 1.9. It's also a required method (though it should probably forward to is_multiple_of), so the deprecation warning would be forced on everyone who implements the trait as well.

@aobatact
Copy link
Contributor Author

Sorry I didn't know that #[deprecated] can't be used in 1.8.
So should we leave it until the min rust version is bumped?
And should we make an fallback to is_multiple_of to make it as provided method?

@cuviper
Copy link
Member

cuviper commented Feb 8, 2024

We have since bumped to 1.31, and I just added the default fallback as you suggested.

@cuviper cuviper added this pull request to the merge queue Feb 8, 2024
Merged via the queue into rust-num:master with commit 3ac8866 Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer::divides is not marked deprecated.
2 participants