Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax trait bounds on serde impl for Complex #119

Merged
merged 2 commits into from Feb 6, 2024
Merged

Relax trait bounds on serde impl for Complex #119

merged 2 commits into from Feb 6, 2024

Conversation

WalterSmuts
Copy link
Contributor

Fixes: #118

@WalterSmuts WalterSmuts mentioned this pull request Dec 5, 2023
Closed
@WalterSmuts WalterSmuts mentioned this pull request Jan 11, 2024
Closed
cuviper
cuviper approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, thanks!

I need to fixup all num CI now that bors is gone though. I'll try to get to that soon...

@cuviper cuviper added this pull request to the merge queue Feb 6, 2024
Merged via the queue into rust-num:master with commit 0eb3e90 Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why require T : Num for implementing Deserialize for Complex<T>
2 participants
@WalterSmuts @cuviper