Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iter_u32_digits , iter_u64_digits, to_u64_digits to both BigInt and BigUint #192

Merged
merged 18 commits into from Feb 24, 2021
Merged

Add iter_u32_digits , iter_u64_digits, to_u64_digits to both BigInt and BigUint #192

merged 18 commits into from Feb 24, 2021

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Feb 24, 2021

This is a rebase of #158, and I also addressed my last review comments there. I did rename the iterators to U32Digits and U64Digits, but I left the iter_ prefix on the methods so they're not confused with the similar to_ methods.

Speedy37 and others added 18 commits February 24, 2021 13:47
@Speedy37 @cuviper
Add iter_u32_digits and iter_u64_digits to biguint
f718847
@Speedy37 @cuviper
add iter_u32_digits, iter_u64_digits, to_u64_digits to BigInt
9f44a8f
@Speedy37 @cuviper
fix Copied is not available before 1.35.0
a00278b
@Speedy37 @cuviper
replace std::slice::x to core::slice::x
51a94c5
@Speedy37 @cuviper
fix 32bits build
b0bed64
@cuviper
More idiomatic lifetime declaration & fix comments
d9e188b 
Co-authored-by: Josh Stone <cuviper@gmail.com>
@cuviper
use iterator .cloned instead of map in IterU32Digits
d819767 
Co-authored-by: Josh Stone <cuviper@gmail.com>
@Speedy37 @cuviper
fix IterU32Digits len returns value is invalid
8168d80
@Speedy37 @cuviper
fix iter_ux_digits comment
1f324ca
@Speedy37 @cuviper
more idiomatic iter_x_digits impl
7c85952
@Speedy37 @cuviper
fix iter_u32_digits comment
3ee03f0
@Speedy37 @cuviper
document IterUxDigits structs
48310c1
@Speedy37 @cuviper
more idiomatic iter_x_digits impl
2f9dc12
@Speedy37 @cuviper
add inline mark to IterUXDigits
aeb8e30
@cuviper
Rename iterators to U32Digits and U64Digits
a25fec6
@cuviper
Re-export the iterators in the root
5f7471a
@cuviper
unify ExactSizeIterator for U64Digits
fea0bee
@cuviper
Add multi-digit 64-bit examples
0037a7f
@cuviper
Copy link
Member Author

cuviper commented Feb 24, 2021

cc @Speedy37

@cuviper
Copy link
Member Author

cuviper commented Feb 24, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 24, 2021

Build succeeded:

@bors bors bot merged commit d9287a4 into rust-num:master Feb 24, 2021
@cuviper cuviper mentioned this pull request Feb 24, 2021
Closed
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cuviper @Speedy37