Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rand to 0.8 #185

Merged
merged 6 commits into from Mar 5, 2021
Merged

Bump rand to 0.8 #185

merged 6 commits into from Mar 5, 2021

Conversation

Gelbpunkt
Copy link
Contributor

This updates rand to 0.8, which is required when working with a 0.8 version in the package since the version needs to match for the trait.

@cuviper
Copy link
Member

cuviper commented Jan 5, 2021

Hi, and thanks! This will need updates in ci/big_rand as well.

Updating a public dependency is a breaking change, so I would like to wait for quickcheck and arbitrary to update too, and we can bump them all in one release. It looks like both of those are getting ready for their 1.0 releases.
(The update PRs can be handled separately though.)

@Gelbpunkt
Copy link
Contributor Author

Hi, and thanks! This will need updates in ci/big_rand as well.

Done 😄

Updating a public dependency is a breaking change, so I would like to wait for quickcheck and arbitrary to update too, and we can bump them all in one release. It looks like both of those are getting ready for their 1.0 releases.

Sounds great 👍

@cuviper
Copy link
Member

cuviper commented Mar 5, 2021

Thanks for your patience! I'm getting ready for 0.4 now...

bors r+

bors bot added a commit that referenced this pull request Mar 5, 2021
185: Bump rand to 0.8 r=cuviper a=Gelbpunkt

This updates rand to 0.8, which is required when working with a 0.8 version in the package since the version needs to match for the trait.

Co-authored-by: Jens Reidel <adrian@travitia.xyz>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 5, 2021

Build failed:

@cuviper
Copy link
Member

cuviper commented Mar 5, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 5, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants