-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better reshaping, part 1: .to_shape() #982
Merged
Merged
Commits on May 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 31c71da - Browse repository at this point
Copy the full SHA 31c71daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d094bf - Browse repository at this point
Copy the full SHA 0d094bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3794952 - Browse repository at this point
Copy the full SHA 3794952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8032aec - Browse repository at this point
Copy the full SHA 8032aecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a26bf94 - Browse repository at this point
Copy the full SHA a26bf94View commit details -
To generalize over Forward/Reverse indexing of dimensions, add simple traits Sequence/Mut that allow indexing forwards and reversed references of dimension values. In a future change, they will support strides (with isize values) too.
Configuration menu - View commit details
-
Copy full SHA for b157cc6 - Browse repository at this point
Copy the full SHA b157cc6View commit details -
shape: Add function for reshape while preserving memory layout
This function can compute the strides needed and if it's possible to reshape an array with given strides into a different shape. This happens using a given Order::{C, F}.
Configuration menu - View commit details
-
Copy full SHA for 2d42e5f - Browse repository at this point
Copy the full SHA 2d42e5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9af569 - Browse repository at this point
Copy the full SHA c9af569View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4467cd8 - Browse repository at this point
Copy the full SHA 4467cd8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.