Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement co-broadcasting in operator overloading #898

Merged
merged 16 commits into from Mar 12, 2021
Merged

Implement co-broadcasting in operator overloading #898

merged 16 commits into from Mar 12, 2021

Commits on Mar 12, 2021

  1. Fix co_broadcast in operator overloading

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    f7a9491 View commit details
    Browse the repository at this point in the history

  2. Add BroadCastShape<Ix0> to the Dimension definition

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    5e77eed View commit details
    Browse the repository at this point in the history

  3. add BroadCastShape<<Self as Dimension>::Smaller>

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    e8b29e1 View commit details
    Browse the repository at this point in the history

  4. use uninitialized to avoid traversing or cloning

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    f7c9da1 View commit details
    Browse the repository at this point in the history

  5. Use MaybeUninitSubst and Zip to avoid uninitialized(), rename BroadCa… 

    …stOutput to Output, remove zip_mut_from_pair()
    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    0561c13 View commit details
    Browse the repository at this point in the history

  6. treat zero dimension like numpy does

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    fc969bd View commit details
    Browse the repository at this point in the history

  7. rebase and use map_collect_owned in impl_ops.rs

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    a19149b View commit details
    Browse the repository at this point in the history

  8. use izip in index loop in broadcast.rs

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    b1f4f95 View commit details
    Browse the repository at this point in the history

  9. Update documentation and function names

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    c9eb88e View commit details
    Browse the repository at this point in the history

  10. Update documentation and function names

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    e3b73cc View commit details
    Browse the repository at this point in the history

  11. Add function broadcast_with

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    b623239 View commit details
    Browse the repository at this point in the history

  12. Modify the docs and visibility of broadcast_with

    @SparrowLii @bluss
    SparrowLii authored and bluss committed Mar 12, 2021
    Copy the full SHA
    c24e602 View commit details
    Browse the repository at this point in the history

  13. TEST: Remove unused imports in tests/broadcast.rs

    @bluss
    bluss committed Mar 12, 2021
    Copy the full SHA
    16f382b View commit details
    Browse the repository at this point in the history

  14. FIX: Rename BroadcastShape to DimMax 

    For consistency with other dimension traits (to come);
with <A as DimMax<B>>, Output is the maximum of A and B.
    @bluss
    bluss committed Mar 12, 2021
    Copy the full SHA
    b39593e View commit details
    Browse the repository at this point in the history

  15. FIX: Remove broadcast_shape from the DimMax trait 

    While calling co_broadcast directly is less convenient, for now they are
two different functions.
    @bluss
    bluss committed Mar 12, 2021
    Copy the full SHA
    38f7341 View commit details
    Browse the repository at this point in the history

  16. MAINT: Fix clippy warnings for broadcast_with

    @bluss
    bluss committed Mar 12, 2021
    Copy the full SHA
    03cfdfc View commit details
    Browse the repository at this point in the history