Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error-check array shape before computing strides #855

Merged
merged 2 commits into from Dec 3, 2020
Merged

Error-check array shape before computing strides #855

merged 2 commits into from Dec 3, 2020

Commits on Dec 3, 2020

  1. MAINT: Fix misspelling in workflow file

    @bluss
    bluss committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    4549b00 View commit details
    Browse the repository at this point in the history

  2. FIX: Error-check array shape before computing strides 

    Update StrideShape's representation to use enum { C, F, Custom(D) } so
that we don't try to compute a C or F stride set until after we have
checked the actual array shape.

This avoids overflow errors (that panic) in places where we expected to
return an error. It was visible as a test failure on 32-bit that long
went undetected because tests didn't run on such platforms before (but
the bug affected all platforms, given sufficiently large inputs).

Also move the Shape, StrideShape types into the shape builder module.
It all calls out for a nicer organization of types that makes
constructors easier to understand for users, but that's an issue for
another time - and it's a breaking change.
    @bluss
    bluss committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    c195930 View commit details
    Browse the repository at this point in the history