Combine common code / reduce codegen by factoring out common parts #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split these shape check functions into parts that don't require using the element type as a generic parameter. This means that less instantiations of this code is needed for a typical user of ndarray.
Remove redundant .clone() and simplify inner loop
The original design was that the apply cores were "resumable", and thus we'd put the dimension "back in order" when exiting the method. However, this is not in use today (and loop break from FoldWhile also bypasses this tail code, anyway), so just remove this unused line.
The innermost loop is the stretch of constant stride (for the contiguous case, this is the whole loop); with a lot of function arguments, this part is actually commmon to the three loops (contig, c, and f). Also make a small simplification of this inner loop; use a while loop to have less code to compile in this much instantiated function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to reduce the amount of code (as counted by cargo-llvm-lines) generated for our functions.