Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip: Handle preferred memory layout of inhomogenous inputs better #809

Merged
merged 7 commits into from Apr 23, 2020

Commits on Apr 22, 2020

  1. FIX: Layout, make all the constructors pub(crate)

    They were previously pub, just because we didn't have the pub(crate)
    feature yet.
    bluss committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f6239c0 View commit details
    Browse the repository at this point in the history
  2. TEST: Zip vs Zip::indexed etc benchmarks

    nilgoyette authored and bluss committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2a44fb6 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. TEST: Test non-contig arrays in Zip benchmarks, also with splits

    Using split tests performance of the Zip in parallelization, so that we
    can see if there are benefits to splitting arrays better.
    bluss committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    55998bb View commit details
    Browse the repository at this point in the history
  2. TEST: In Zip benchmarks, use the index

    Using the index shows more directly the overhead of indexed zip
    bluss committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    90ef196 View commit details
    Browse the repository at this point in the history
  3. FEAT: Keep track of "layout tendency" in Zip for better performance

    Support both unroll over c- and f-layout preferred axis in Zip inner loop
    (the fallback when inputs are not all contiguous and same layout).
    
    Keep a tendency score when building the Zip, so that we know if the
    inputs are tending to be c- or f- layout.
    
    This improves performance on the just added zip_indexed_ff benchmark, so
    that it seems to match its (already fast) cc counterpart.
    bluss committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a659235 View commit details
    Browse the repository at this point in the history
  4. TEST: Add tests for Layout

    bluss committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    a3d53d2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    47b3654 View commit details
    Browse the repository at this point in the history