Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .fold() method to Zip #684

Merged
merged 1 commit into from Sep 3, 2019
Merged

Add .fold() method to Zip #684

merged 1 commit into from Sep 3, 2019

Conversation

jturner314
Copy link
Member

This is just for convenience to avoid having to deal with FoldWhile.

@LukeMathWalker
Copy link
Member

This makes the API nicer to use - I don't see any downside, we can go ahead and merge.

@jturner314 jturner314 merged commit 35065cb into rust-ndarray:master Sep 3, 2019
@jturner314 jturner314 deleted the zip-fold branch September 3, 2019 23:38
@jturner314
Copy link
Member Author

Thanks for reviewing this @LukeMathWalker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

@Jvanrhijn Jvanrhijn Jvanrhijn left review comments

@LukeMathWalker LukeMathWalker LukeMathWalker approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jturner314 @LukeMathWalker @max-sixty @Jvanrhijn