New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As standard layout method #616
As standard layout method #616
Commits on Apr 3, 2019
-
Merge pull request #1 from rust-ndarray/master
Merge main rep master to fork master
Andrew committedApr 3, 2019 Configuration menu - View commit details
-
Copy full SHA for b39a0bb - Browse repository at this point
Copy the full SHA b39a0bbView commit details
Commits on Apr 12, 2019
-
Implemented
as_contiguous
methodandrei-papou committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for c0890db - Browse repository at this point
Copy the full SHA c0890dbView commit details -
Added content check for the new array to the tests
andrei-papou committedApr 12, 2019 Configuration menu - View commit details
-
Copy full SHA for 4ea2c7d - Browse repository at this point
Copy the full SHA 4ea2c7dView commit details
Commits on Apr 26, 2019
-
Return CowArray from as_contiguous instead of Array
andrei-papou committedApr 26, 2019 Configuration menu - View commit details
-
Copy full SHA for 5cdae91 - Browse repository at this point
Copy the full SHA 5cdae91View commit details -
andrei-papou committed
Apr 26, 2019 Configuration menu - View commit details
-
Copy full SHA for c82359a - Browse repository at this point
Copy the full SHA c82359aView commit details
Commits on Apr 28, 2019
-
Fixed wording + minor improvements
andrei.papou committedApr 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 5ce8d31 - Browse repository at this point
Copy the full SHA 5ce8d31View commit details
Commits on Apr 30, 2019
-
Added more tests + 2 methods for ArrayCow
andrei-papou committedApr 30, 2019 Configuration menu - View commit details
-
Copy full SHA for 2a67f25 - Browse repository at this point
Copy the full SHA 2a67f25View commit details
Commits on May 3, 2019
-
Split single test into multiple ones
Moved all `as_standard_layout`-related tests to the separate module
andrei-papou committedMay 3, 2019 Configuration menu - View commit details
-
Copy full SHA for 2d453c7 - Browse repository at this point
Copy the full SHA 2d453c7View commit details
Commits on May 5, 2019
-
Fix try_ensure_unique for CowRepr
The old implementation incorrectly handled the strides when the array was not in standard layout. (It created a `Vec` corresponding to an array in standard layout but didn't update the strides accordingly.) The new implementation calls `.to_owned()`, which handles the problem of efficiently creating an owned array, and then moves all the field values. Additionally, the `ensure_is_owned` function has been removed because it's equivalent to `DataMut::ensure_unique`.
Configuration menu - View commit details
-
Copy full SHA for 0d54de5 - Browse repository at this point
Copy the full SHA 0d54de5View commit details -
Remove into_view/owned_array from ArrayCow
These functions were used only in the implementation of `CowRepr::to_owned`. They may turn out to be useful in the future, but until there's a clear use case that is not served by `.view()` and `.into_owned()`, let's remove them.
Configuration menu - View commit details
-
Copy full SHA for 1f4499f - Browse repository at this point
Copy the full SHA 1f4499fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ede464 - Browse repository at this point
Copy the full SHA 2ede464View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17e074b - Browse repository at this point
Copy the full SHA 17e074bView commit details -
Impl clone_from_with_ptr for differing CowRepr variants
The old implementation panicked when the variants were different; the new implementation performs the necessary clone instead of panicking. The variant of `self` after calling `clone_from_with_ptr` should match the variant of `other`. If the variants are initially different, the data from `other` needs to be cloned, and `self` needs to be changed to that variant.
Configuration menu - View commit details
-
Copy full SHA for 5506113 - Browse repository at this point
Copy the full SHA 5506113View commit details -
Configuration menu - View commit details
-
Copy full SHA for 556bd59 - Browse repository at this point
Copy the full SHA 556bd59View commit details
Commits on May 6, 2019
-
Move ArrayCow method impls into separate module
This is analogous to `impl_owned_array`, `impl_views`, and `impl_raw_views`.
Configuration menu - View commit details
-
Copy full SHA for 3101ca3 - Browse repository at this point
Copy the full SHA 3101ca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131aea7 - Browse repository at this point
Copy the full SHA 131aea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d68ea6 - Browse repository at this point
Copy the full SHA 0d68ea6View commit details -
Remove A: Clone bound from CowRepr
In the vast majority of cases, `A` will implement `Clone`. However, `ArrayCow` may still be useful for cases where `A` does not implement `Clone`.
Configuration menu - View commit details
-
Copy full SHA for b84b3ec - Browse repository at this point
Copy the full SHA b84b3ecView commit details -
Use .raw_dim() instead of .dim()
The compiler should have a slightly easier time making this efficient because there are fewer type conversions this way.
Configuration menu - View commit details
-
Copy full SHA for ebd6cc4 - Browse repository at this point
Copy the full SHA ebd6cc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b14b3de - Browse repository at this point
Copy the full SHA b14b3deView commit details -
Merge pull request #4 from jturner314/as-contiguous-method
Refine Cow stuff and as_standard_layout impl
Andrew committedMay 6, 2019 Configuration menu - View commit details
-
Copy full SHA for 9ec732a - Browse repository at this point
Copy the full SHA 9ec732aView commit details
Commits on May 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for efd686d - Browse repository at this point
Copy the full SHA efd686dView commit details
Commits on May 31, 2019
-
andrei-papou committed
May 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 1417bcb - Browse repository at this point
Copy the full SHA 1417bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cd5d5a - Browse repository at this point
Copy the full SHA 8cd5d5aView commit details -
Merge branch 'master' of github.com:andrei-papou/ndarray into as-cont…
…iguous-method
andrei-papou committedMay 31, 2019 Configuration menu - View commit details
-
Copy full SHA for d85d4a8 - Browse repository at this point
Copy the full SHA d85d4a8View commit details -
andrei-papou committed
May 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 4c2d2dd - Browse repository at this point
Copy the full SHA 4c2d2ddView commit details -
andrei-papou committed
May 31, 2019 Configuration menu - View commit details
-
Copy full SHA for ac51cfd - Browse repository at this point
Copy the full SHA ac51cfdView commit details
Commits on Jun 3, 2019
-
- reduced the amount of the boilerplate code in related tests - added explicit assertion about the size of the source array when copying it to the standard layout. - added documentation string to the new method - removed redundant import
andrei-papou committedJun 3, 2019 Configuration menu - View commit details
-
Copy full SHA for c2ae416 - Browse repository at this point
Copy the full SHA c2ae416View commit details
Commits on Jun 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 02d181d - Browse repository at this point
Copy the full SHA 02d181dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f669f0f - Browse repository at this point
Copy the full SHA f669f0fView commit details