Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for inserting new axes while slicing #570

Merged
merged 28 commits into from Mar 13, 2021
Merged

Add support for inserting new axes while slicing #570

merged 28 commits into from Mar 13, 2021

Commits on Mar 12, 2021

  1. Rename SliceOrIndex to AxisSliceInfo

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    24a3299 View commit details
    Browse the repository at this point in the history

  2. Switch from Dimension::SliceArg to CanSlice trait

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    6a16b88 View commit details
    Browse the repository at this point in the history

  3. Add support for inserting new axes while slicing

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    546b69c View commit details
    Browse the repository at this point in the history

  4. Rename SliceInfo generic params to Din and Dout

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    6e335ca View commit details
    Browse the repository at this point in the history

  5. Improve code style

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    d6b9cb0 View commit details
    Browse the repository at this point in the history

  6. Derive Clone, Copy, and Debug for NewAxis

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    438d69a View commit details
    Browse the repository at this point in the history

  7. Use stringify! for string literal of type name

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    6050df3 View commit details
    Browse the repository at this point in the history

  8. Make step_by panic for variants other than Slice

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    8d45268 View commit details
    Browse the repository at this point in the history

  9. Add DimAdd trait

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    1d15275 View commit details
    Browse the repository at this point in the history

  10. Replace SliceNextIn/OutDim with SliceArg trait

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    41cc4a1 View commit details
    Browse the repository at this point in the history

  11. Combine DimAdd impls for Ix0

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    c66ad8c View commit details
    Browse the repository at this point in the history

  12. Implement CanSlice<IxDyn> for [AxisSliceInfo]

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    7776bfc View commit details
    Browse the repository at this point in the history

  13. Change SliceInfo to be repr(transparent)

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    ab79d28 View commit details
    Browse the repository at this point in the history

  14. Add debug assertions to SliceInfo::new_unchecked

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    615113e View commit details
    Browse the repository at this point in the history

  15. Fix safety of SliceInfo::new

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    e66e3c8 View commit details
    Browse the repository at this point in the history

  16. Add some impls of TryFrom for SliceInfo

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    3ba6ceb View commit details
    Browse the repository at this point in the history

  17. Make slice_move not call slice_collapse 

    This isn't much more code and simplifies the logic somewhat.
    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    815e708 View commit details
    Browse the repository at this point in the history

  18. Make slice_collapse return Err(_) for NewAxis

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    25a7bb0 View commit details
    Browse the repository at this point in the history

  19. Expose CanSlice trait in public API 

    This makes it visible in the docs, but the private marker trick
prevents other crates from implementing it.
    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    5202a50 View commit details
    Browse the repository at this point in the history

  20. Expose MultiSlice trait in public API 

    This makes it visible in the docs, but the private marker trick
prevents other crates from implementing it.
    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    319701d View commit details
    Browse the repository at this point in the history

  21. Add DimAdd bounds to Dimension trait 

    This reduces how often an explicit `DimAdd` bound is necessary.
    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    d5d6482 View commit details
    Browse the repository at this point in the history

  22. Revert "Make slice_collapse return Err(_) for NewAxis" 

    This reverts commit 3815462.
    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    9614b13 View commit details
    Browse the repository at this point in the history

  23. Make slice_collapse panic on NewAxis

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    61cf7c0 View commit details
    Browse the repository at this point in the history

  24. Rename DimAdd::Out to DimAdd::Output

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    91dbf3f View commit details
    Browse the repository at this point in the history

  25. Rename SliceArg to SliceNextDim

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    5dc77bd View commit details
    Browse the repository at this point in the history

  26. Rename CanSlice to SliceArg

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    87515c6 View commit details
    Browse the repository at this point in the history

  27. Rename MultiSlice to MultiSliceArg

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    c4efbbf View commit details
    Browse the repository at this point in the history

  28. Clarify docs of .slice_collapse()

    @jturner314 @bluss
    jturner314 authored and bluss committed Mar 12, 2021
    Copy the full SHA
    7506f90 View commit details
    Browse the repository at this point in the history