Test using cargo-careful #1371
Merged
Test using cargo-careful #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it ran correctly here: https://github.com/rust-ndarray/ndarray/actions/runs/8216936059/job/22472060567 |
My understanding was that Miri would not handling calling into BLAS et al. |
adamreichold
approved these changes
Mar 9, 2024
|
I see. It's been attempted before, such as by jturner in commit 784a9a8 apparently. He added a miri runner in matrixmultiply at least, but we don't have it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @adamreichold.
I think we could test with miri too, the problem is that it's very slow.