Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ci so that most checks run in merge queue only #1368

Merged
merged 2 commits into from Mar 9, 2024
Merged

Setup ci so that most checks run in merge queue only #1368

merged 2 commits into from Mar 9, 2024

Conversation

bluss
Copy link
Member

@bluss bluss commented Mar 9, 2024

Adopt conclusion job that summarizes ci status.
Originally contributed by @messense in pyo3, copied their solution with thanks.

@bluss bluss added this pull request to the merge queue Mar 9, 2024
@bluss
Copy link
Member Author

bluss commented Mar 9, 2024

The merge queue now working on the right things I think: https://github.com/rust-ndarray/ndarray/actions/runs/8215462578

I listed the required checks in branch protection. I could list tests, cross_tests as those entries (not each test matrix entry, that resolves that problem for me).

And mark those as being skipped for regular PR check (see the yaml file). Too early for bors-ng to be deprecated seeing how this works(!) 🙂

@adamreichold
Copy link
Collaborator

I listed the required checks in branch protection. I could list tests, cross_tests as those entries (not each test matrix entry, that resolves that problem for me).

IIRC, in PyO3 we solved this by having a single job collect the state of all the other jobs (which I think is also the usual approach applied with bors).

@bluss
Copy link
Member Author

bluss commented Mar 9, 2024

Oh, it ran all the right things but the required checks don't work like this. It autocompleted to tests and cross_tests for the required tests in the UI, but in CI it expands to the matrix of tests so the names are tests (stable) and so on. Everything's finished but it is still waiting.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 9, 2024
@bluss bluss force-pushed the ci branch 5 times, most recently from ed6e9bf to b4440c3 Compare March 9, 2024 16:29
@bluss bluss added this pull request to the merge queue Mar 9, 2024
Originally contributed by @messense in pyo3, copied their solution with
thanks.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2024
@bluss bluss added this pull request to the merge queue Mar 9, 2024
Merged via the queue into master with commit 54b3ffb Mar 9, 2024
4 checks passed
@bluss bluss deleted the ci branch March 9, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants