Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zip::any #1228

Merged
merged 1 commit into from Mar 10, 2024
Merged

Add Zip::any #1228

merged 1 commit into from Mar 10, 2024

Conversation

nilgoyette
Copy link
Collaborator

I find it strange that ndarray offers Zip::all but not Zip::any. Of course we can replace this function with normal iteration tools from std and itertools, but Zip is the by far fastest horse around.

I checked with Python and C++ for the Returns false if the input arrays are empty behavior.

@bluss
Copy link
Member

bluss commented May 6, 2023

any(p) is the same as !all(!p) and I've previously been against bloating the list of adaptors here, but it seems fine.

@bluss bluss enabled auto-merge March 10, 2024 13:03
@bluss bluss added this to the 0.16.0 milestone Mar 10, 2024
@bluss bluss added this pull request to the merge queue Mar 10, 2024
Merged via the queue into rust-ndarray:master with commit 3492a9c Mar 10, 2024
8 checks passed
@bluss
Copy link
Member

bluss commented Mar 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants