Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SvdWork, merge lax::SVD_ into Lapack trait #345

Merged
merged 9 commits into from Sep 28, 2022
Merged

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Sep 27, 2022

Same as #340, #341, #343 for #168

@termoshtt termoshtt self-assigned this Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #345 (d75c693) into master (b74552e) will increase coverage by 0.62%.
The diff coverage is 98.40%.

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   89.42%   90.05%   +0.62%     
==========================================
  Files          74       74              
  Lines        4238     4525     +287     
==========================================
+ Hits         3790     4075     +285     
- Misses        448      450       +2     
Impacted Files Coverage Δ
ndarray-linalg/src/least_squares.rs 96.15% <0.00%> (ø)
lax/src/svd.rs 97.35% <96.85%> (+1.27%) ⬆️
lax/src/least_squares.rs 100.00% <100.00%> (ø)
lax/src/lib.rs 100.00% <100.00%> (ø)
lax/src/svddc.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt changed the title Merge SVD_ to Lapack trait Merge SVD_ and SVDDC_ traits to Lapack trait Sep 27, 2022
@termoshtt termoshtt added the breaking change Non-compatible change label Sep 27, 2022
@termoshtt termoshtt changed the title Merge SVD_ and SVDDC_ traits to Lapack trait Merge SVD_, SVDDC_, and LeastSquaresSvdDivideConquer_ to Lapack trait Sep 28, 2022
@termoshtt termoshtt marked this pull request as ready for review September 28, 2022 15:47
@termoshtt termoshtt merged commit 07ab31d into master Sep 28, 2022
@termoshtt termoshtt deleted the lax-svd-strict branch September 28, 2022 16:17
@termoshtt termoshtt added new feature and removed breaking change Non-compatible change labels Oct 3, 2022
@termoshtt termoshtt changed the title Merge SVD_, SVDDC_, and LeastSquaresSvdDivideConquer_ to Lapack trait Add SvdWork, merge lax::SVD_ into Lapack trait Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant